From ff986850159a1ea0c75617ffa792d1bb2069856e Mon Sep 17 00:00:00 2001 From: Federico Mena Quintero Date: Wed, 29 May 2019 17:14:27 -0500 Subject: [PATCH 12/14] Change a magic number (6) for a constant (BZ_N_GROUPS). decompress.c (BZ2_decompress): Check nGroups against BZ_N_GROUPS. --- decompress.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/decompress.c b/decompress.c index f3db91d..7351134 100644 --- a/decompress.c +++ b/decompress.c @@ -285,7 +285,7 @@ Int32 BZ2_decompress ( DState* s ) /*--- Now the selectors ---*/ GET_BITS(BZ_X_SELECTOR_1, nGroups, 3); - if (nGroups < 2 || nGroups > 6) RETURN(BZ_DATA_ERROR); + if (nGroups < 2 || nGroups > BZ_N_GROUPS) RETURN(BZ_DATA_ERROR); GET_BITS(BZ_X_SELECTOR_2, nSelectors, 15); if (nSelectors < 1 || nSelectors > BZ_MAX_SELECTORS) RETURN(BZ_DATA_ERROR); for (i = 0; i < nSelectors; i++) { -- 2.22.0